dinyar / uGMTfirmware

Firmware for the CMS uGMT.
0 stars 4 forks source link

The address table should be cleaned up! #235

Open jlingema opened 9 years ago

jlingema commented 9 years ago

The address table has inconsistent naming in many places. Examples are:

Furthermore, most comments / description fields are not helpful at all. Example: <node id="mu_quad0" address="0x0" module="file://mu_quad_deserialization.xml" description="Access to registers and LUTs in a muon quad." /> Here something like "Access to registers/LUTs for positive endcap receiving channels" would be more helpful. I find this is true for most of the descriptions.

dinyar commented 9 years ago

@jlingema I've started this, but realized that the firmware logic itself doesn't care about the calo energy sum mapping to coordinates. Could you let me know which channels we expect to correspond to which eta value?

dinyar commented 9 years ago

Ah, forgot I was still waiting for the energy sum mapping. Reopening.

dinyar commented 8 years ago

Reassigned to @thomreis. Is it useful to have the mapping of energy sum input channels to eta value in the address table? In that case, could you let me know what the mapping is in the LUTs currently?