search

dinyar / uGMTfirmware

Firmware for the CMS uGMT.
0 stars 4 forks source link

Hardcoded magic numbers should be removed in extrapolation logic. #248

Closed dinyar closed 9 years ago

dinyar commented 9 years ago

In https://github.com/dinyar/uGMTfirmware/blob/338428ec8cf42ebdcf6c8033fc1a70a1b28e0e0b/uGMT_algos/firmware/hdl/deserializer_stages/gen_idx_bits.vhd#L147, https://github.com/dinyar/uGMTfirmware/blob/338428ec8cf42ebdcf6c8033fc1a70a1b28e0e0b/uGMT_algos/firmware/hdl/deserializer_stages/gen_idx_bits.vhd#L149, https://github.com/dinyar/uGMTfirmware/blob/338428ec8cf42ebdcf6c8033fc1a70a1b28e0e0b/uGMT_algos/firmware/hdl/deserializer_stages/gen_idx_bits.vhd#L155, and https://github.com/dinyar/uGMTfirmware/blob/338428ec8cf42ebdcf6c8033fc1a70a1b28e0e0b/uGMT_algos/firmware/hdl/deserializer_stages/gen_idx_bits.vhd#L156

the indices should be replaced by EXTRAPOLATION_LATENCY-1 and EXTRAPOLATION_LATENCY-2, respectively.