search

dinyar / uGMTfirmware

Firmware for the CMS uGMT.
0 stars 4 forks source link

Use eta-fine bit in cancel-out unit #323

Closed dinyar closed 8 years ago

dinyar commented 8 years ago

The BMTF sends an eta-fine bit that is cleared when the eta coordinate could not be measured by the dedicated chambers but had to be determined from the muon station the muon was detected in. In this case the eta assigned is the middle-point of the concerned muon station and thus very coarse. The eta-fine bit should therefore be considered by the LUTs used by the cancel-out units for the barrel-overlap region.

dinyar commented 8 years ago

@thomreis Could you generate a LUT content file for the barrel-overlap COU that contains an input for the eta fine bit? In principle it could be with the same dR cut, but if it's easy you could make it larger (e.g. 0.3).

thomreis commented 8 years ago

Why do you want to make the cut value larger when the eta fine bit is set?

dinyar commented 8 years ago

I meant when it isn't set :)

thomreis commented 8 years ago

The emulator code is in PR https://github.com/cms-l1t-offline/cmssw/pull/315

dinyar commented 8 years ago

This probably works (currently in the sort and cancel testbench etaFine is forced to '1' so that part of the LUT is accessed correctly), I'm not absolutely sure if we have muons with etaFine bit cleared at the moment.

Related: We should add a field for the etaFine bit in the sort and cancel testbench input file and adapt the testbench accordingly.

dinyar commented 8 years ago

It looks like the etaFine bit is used correctly, but the test samples used seemed to have not tested behaviour when the bit is not set for one of the muons. If there is a problem we will open a new ticket.