dinyar / uGMTfirmware

Firmware for the CMS uGMT.
0 stars 4 forks source link

Add register to store algo revision #348

Closed dinyar closed 8 years ago

dinyar commented 8 years ago

It would be useful to introduce a register that contains the number of the currently used uGMT version. Ideally this should be checked by the uGMT cell (this will interest @thomreis)

dinyar commented 8 years ago

It might be useful to take this opportunity to make the versioning scheme more explicit. I was imagining something along the following lines:

thomreis commented 8 years ago

I agree that this would be a useful feature to have. I am not sure if this is something that needs to be checked in the monitoring though. The number would only change on a cold reset, so we could make a command that checks during the setup step if the version is the one expected. Of course we could do both.

dinyar commented 8 years ago

A check at setup sounds good to me!

Cheers, Dinyar

On Mon, Apr 25, 2016 at 9:24 AM Thomas Reis notifications@github.com wrote:

I agree that this would be a useful feature to have. I am not sure if this is something that needs to be checked in the monitoring though. The number would only change on a cold reset, so we could make a command that checks during the setup step if the version is the one expected. Of course we could do both.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/dinyar/uGMTfirmware/issues/348#issuecomment-214179277

thomreis commented 8 years ago

This would mean that the FW version is also stored in the configuration DB.

dinyar commented 8 years ago

This has actually been available via the mp7fw for a while: https://github.com/dinyar/uGMTfirmware/blob/993386d5300549559eb9a316a569f2568777c87d/uGMT_algos/firmware/hdl/top_decl.vhd#L14

We should use that facility instead.

thomreis commented 8 years ago

There is a new common MP7 SWATCH command that checks the FW versions. It just needs to be executed.

dinyar commented 8 years ago

Ok, perfect thanks. Are you "unpacking" the hardware register word? i.e. can the version be written as e.g. 2.1.0(or 2.1.0_patch5) in the database and the cell compares it against the word 02010000 (or 02010005)?

thomreis commented 8 years ago

I have to speak with Alessandro about that. As I understand he just compares to two numbers. One for the MP7 FW and one for the algo.