I attempted to use your tool to install the puppet agent on a new ubuntu cloud server. It fails with error installing keys. As you can see at the bottom of my output the keys installed, but it seems 3 of the 4 keys are expired which I suspect is the reason for the failure.
TASK [diodonfrost.puppet_agent : Ubuntu | Add Puppetlabs apt key] **
failed: [] (item=https://apt.puppetlabs.com/DEB-GPG-KEY-puppet) => {"after": ["4528B6CD9E61EF26", "D94AA3F0EFE21092", "871920D1991BC93C"], "ansible_loop_var": "item", "before": ["4528B6CD9E61EF26", "D94AA3F0EFE21092", "871920D1991BC93C"], "changed": true, "fp": "7F438280EF8D349F", "id": "7F438280EF8D349F", "item": "https://apt.puppetlabs.com/DEB-GPG-KEY-puppet", "key_id": "7F438280EF8D349F", "msg": "apt-key did not return an error, but failed to add the key (check that the id is correct and not a subkey)", "short_id": "EF8D349F"}
ok: [] => (item=https://apt.puppetlabs.com/DEB-GPG-KEY-puppet-20250406)
failed: [] (item=https://apt.puppetlabs.com/DEB-GPG-KEY-puppetlabs) => {"after": ["4528B6CD9E61EF26", "D94AA3F0EFE21092", "871920D1991BC93C"], "ansible_loop_var": "item", "before": ["4528B6CD9E61EF26", "D94AA3F0EFE21092", "871920D1991BC93C"], "changed": true, "fp": "1054B7A24BD6EC30", "id": "1054B7A24BD6EC30", "item": "https://apt.puppetlabs.com/DEB-GPG-KEY-puppetlabs", "key_id": "1054B7A24BD6EC30", "msg": "apt-key did not return an error, but failed to add the key (check that the id is correct and not a subkey)", "short_id": "4BD6EC30"}
failed: [] (item=https://apt.puppetlabs.com/DEB-GPG-KEY-reductive) => {"after": ["4528B6CD9E61EF26", "D94AA3F0EFE21092", "871920D1991BC93C"], "ansible_loop_var": "item", "before": ["4528B6CD9E61EF26", "D94AA3F0EFE21092", "871920D1991BC93C"], "changed": true, "fp": "FFAC86588347A27F", "id": "FFAC86588347A27F", "item": "https://apt.puppetlabs.com/DEB-GPG-KEY-reductive", "key_id": "FFAC86588347A27F", "msg": "apt-key did not return an error, but failed to add the key (check that the id is correct and not a subkey)", "short_id": "8347A27F"}
I attempted to use your tool to install the puppet agent on a new ubuntu cloud server. It fails with error installing keys. As you can see at the bottom of my output the keys installed, but it seems 3 of the 4 keys are expired which I suspect is the reason for the failure.
$ ansible-playbook -i ~/ansible/inventory.yml ~/ansible/wtf-playbooks/install-puppet-agent.yml
PLAY [] **
TASK [Gathering Facts] ***** ok: []
TASK [diodonfrost.puppet_agent : Include OS specific variables.] *** ok: []
TASK [diodonfrost.puppet_agent : Install Puppetlabs repository] **** included: /home/jim/.ansible/roles/diodonfrost.puppet_agent/tasks/repository/install-repository.yml for
TASK [diodonfrost.puppet_agent : set_fact] ***** skipping: []
TASK [diodonfrost.puppet_agent : Amazonlinux | Add Puppetlabs rpm key] ***** skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppet)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppet-20250406)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppetlabs)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-reductive)
TASK [diodonfrost.puppet_agent : Amazonlinux | Add Puppetlabs repository] ** skipping: []
TASK [diodonfrost.puppet_agent : Amazonlinux | Add Puppetlabs source repository] *** skipping: []
TASK [diodonfrost.puppet_agent : CentOS | Add Puppetlabs rpm key] ** skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppet)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppet-20250406)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppetlabs)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-reductive)
TASK [diodonfrost.puppet_agent : CentOS | Add Puppetlabs repository] *** skipping: []
TASK [diodonfrost.puppet_agent : CentOS | Add Puppetlabs source repository] **** skipping: []
TASK [diodonfrost.puppet_agent : Debian | Add Puppetlabs apt key] ** skipping: [] => (item=https://apt.puppetlabs.com/DEB-GPG-KEY-puppet)
skipping: [] => (item=https://apt.puppetlabs.com/DEB-GPG-KEY-puppet-20250406)
skipping: [] => (item=https://apt.puppetlabs.com/DEB-GPG-KEY-puppetlabs)
skipping: [] => (item=https://apt.puppetlabs.com/DEB-GPG-KEY-reductive)
TASK [diodonfrost.puppet_agent : Debian | Add Puppetlabs repository] *** skipping: []
TASK [diodonfrost.puppet_agent : Debian | Add Puppetlabs source repository] **** skipping: []
TASK [diodonfrost.puppet_agent : Debian | Update apt cache] **** skipping: []
TASK [diodonfrost.puppet_agent : Fedora | Add Puppetlabs rpm key] ** skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppet)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppet-20250406)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppetlabs)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-reductive)
TASK [diodonfrost.puppet_agent : Fedora | Add Puppetlabs repository] *** skipping: []
TASK [diodonfrost.puppet_agent : Fedora | Add Puppetlabs source repository] **** skipping: []
TASK [diodonfrost.puppet_agent : Suse | Add Puppetlabs rpm key] **** skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppet)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppet-20250406)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppetlabs)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-reductive)
TASK [diodonfrost.puppet_agent : Suse | Add Puppetlabs repository] ***** skipping: []
TASK [diodonfrost.puppet_agent : Suse | Add Puppetlabs rpm key] **** skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppet)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppet-20250406)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppetlabs)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-reductive)
TASK [diodonfrost.puppet_agent : Suse | Add Puppetlabs repository] ***** skipping: []
TASK [diodonfrost.puppet_agent : CentOS | Add Puppetlabs rpm key] ** skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppet)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppet-20250406)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppetlabs)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-reductive)
TASK [diodonfrost.puppet_agent : CentOS | Add Puppetlabs repository] *** skipping: []
TASK [diodonfrost.puppet_agent : CentOS | Add Puppetlabs source repository] **** skipping: []
TASK [diodonfrost.puppet_agent : CentOS | Add Puppetlabs rpm key] ** skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppet)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppet-20250406)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-puppetlabs)
skipping: [] => (item=http://yum.puppetlabs.com/RPM-GPG-KEY-reductive)
TASK [diodonfrost.puppet_agent : CentOS | Add Puppetlabs repository] *** skipping: []
TASK [diodonfrost.puppet_agent : CentOS | Add Puppetlabs source repository] **** skipping: []
TASK [diodonfrost.puppet_agent : Ubuntu | Add Puppetlabs apt key] ** failed: [] (item=https://apt.puppetlabs.com/DEB-GPG-KEY-puppet) => {"after": ["4528B6CD9E61EF26", "D94AA3F0EFE21092", "871920D1991BC93C"], "ansible_loop_var": "item", "before": ["4528B6CD9E61EF26", "D94AA3F0EFE21092", "871920D1991BC93C"], "changed": true, "fp": "7F438280EF8D349F", "id": "7F438280EF8D349F", "item": "https://apt.puppetlabs.com/DEB-GPG-KEY-puppet", "key_id": "7F438280EF8D349F", "msg": "apt-key did not return an error, but failed to add the key (check that the id is correct and not a subkey)", "short_id": "EF8D349F"}
ok: [] => (item=https://apt.puppetlabs.com/DEB-GPG-KEY-puppet-20250406)
failed: [] (item=https://apt.puppetlabs.com/DEB-GPG-KEY-puppetlabs) => {"after": ["4528B6CD9E61EF26", "D94AA3F0EFE21092", "871920D1991BC93C"], "ansible_loop_var": "item", "before": ["4528B6CD9E61EF26", "D94AA3F0EFE21092", "871920D1991BC93C"], "changed": true, "fp": "1054B7A24BD6EC30", "id": "1054B7A24BD6EC30", "item": "https://apt.puppetlabs.com/DEB-GPG-KEY-puppetlabs", "key_id": "1054B7A24BD6EC30", "msg": "apt-key did not return an error, but failed to add the key (check that the id is correct and not a subkey)", "short_id": "4BD6EC30"}
failed: [] (item=https://apt.puppetlabs.com/DEB-GPG-KEY-reductive) => {"after": ["4528B6CD9E61EF26", "D94AA3F0EFE21092", "871920D1991BC93C"], "ansible_loop_var": "item", "before": ["4528B6CD9E61EF26", "D94AA3F0EFE21092", "871920D1991BC93C"], "changed": true, "fp": "FFAC86588347A27F", "id": "FFAC86588347A27F", "item": "https://apt.puppetlabs.com/DEB-GPG-KEY-reductive", "key_id": "FFAC86588347A27F", "msg": "apt-key did not return an error, but failed to add the key (check that the id is correct and not a subkey)", "short_id": "8347A27F"}
PLAY RECAP *****