diogoalexandrefranco / cl-strings

A portable, dependency-free set of utilities to manipulate strings in Common Lisp
MIT License
46 stars 7 forks source link

Adding camel-upper-case, camel-lower-case, kebab-case and snake-case #1

Closed JulienRouse closed 8 years ago

JulienRouse commented 8 years ago

Hello, i saw your post on Reddit and i was inspired to help a bit. I'm fairly inexperienced with Common Lisp so i hope progressing a bit practicing. Don't hesitate to tell me what must be improved and how to improve the quality of this patch if anything don't fit your standards.

I looked Wikipedia for the camel case, and i saw they used camel-lower-case and camel-upper-case to avoid confusion, so i stole the name but it could also be camel-uppercase and camel-lowercase.

diogoalexandrefranco commented 8 years ago

Hi! Thanks Julien, this is cool :)

Do you think you could make it so that we follow the usual "definitions" of the formats?

Thanks for your PR!

JulienRouse commented 8 years ago

I fixed the function to be more in line with what you said to me.

I'm not 100% sure that i tested every case possible, if you see anything i'll happily add what's missing.

diogoalexandrefranco commented 8 years ago

Hey JulienRouse.

Thanks for your PR. I refactored a bit the new functions, for consistency (to accept chars too, for example).

I left your tests as you wrote them and will do the documentation for your new functions now.

Thanks again!

JulienRouse commented 8 years ago

I'm glad that was at least a bit useful.

Good luck with this project, cheers mate.