Fix invalid chars in filename, datetime, check checksums

diogogmt / humblebundle-downloader

Download book from Humble Bundles

MIT License

31 stars 3 forks source link

Fix invalid chars in filename, datetime, check checksums #4

Closed affinityv closed 6 years ago

affinityv commented 7 years ago

adjusted go function to accept full filename, instead of recreating it many times
check sha1 and md5 checksums as collected from json
json provied human name may include invalid characters for file names, replace "/" with "_"
add default of "bundle name" for the download directory, instead of "books" from json order data
use Last-Modified from http headers for created file's timestamp

affinityv commented 7 years ago

Fixes my issues #1, #2 and #3 plus more

affinityv commented 6 years ago

@diogogmt How about this one? I like having downloads having more real timestamps, checksums checked and good file names and more... Don't you think my changes are worth adding?

diogogmt commented 6 years ago

@affinityv

Thank you for creating the issues and opening the PR! I think the changes are great, I'll have time to look at it over the weekend and it should be good to merge.