diogomonica / actuary

An actuary is a business professional who analyzes the financial consequences of risk.
78 stars 14 forks source link

Create Audit type #3

Open diogomonica opened 8 years ago

diogomonica commented 8 years ago

I think we need to create a Check type:

type Check struct {}

type CheckResult struct {
    Check
    Status string
    Output string
}

func (c *Check) Run(client *client.Client) CheckResult {
...
}

func (c *Check) Description() string {
return ""
}

This would probably make the code cleaner, and gives us a good way of adding properties to Checks, such as Description.

/cc @zuBux

zuBux commented 8 years ago

This looks a lot cleaner :+1: ! I will need some time to refactor the code :)

thanasisk commented 8 years ago

@zuBux is the refactoring under way? If yes, how can I contribute? If not, I have some free time this weekend, maybe I can have a go at it?

zuBux commented 8 years ago

Most of the code has been refactored, sometimes more than once, so I'm not sure if this issue is relevant anymore.