search

diogomonica / actuary

An actuary is a business professional who analyzes the financial consequences of risk.
77 stars 14 forks source link

Clean actuary.go #4

Closed diogomonica closed 8 years ago

diogomonica commented 8 years ago

Functions like consoleOutput and jsonOutput, etc, should be in an external file.

Also, the current code in actuary.go (in particular the main() method) should be under cmd/actuary.go. That is the go convention. The only things that should be in actuary.go should be our types (Check, CheckResult, etc)

/cc @zuBux

zuBux commented 8 years ago

Merging checks and actuary packages seems the right thing to do but there is a problem with the current structure. I'm not sure we actually need to have a cmd/actuary.go, since our project is not a library. Maybe we should consider a structure like this:

actuary/
    actuary.go    // package main
    profileutils/
    oututils/
    actuary/       //package actuary
        checks.go
        dockerfiles.go
        ....

checks.go will include all our types, functions while actuary.go will contain only the main() method

diogomonica commented 8 years ago

sounds good

zuBux commented 8 years ago

Should I merge the PR?

/cc @diogomonica

diogomonica commented 8 years ago

Yeah, LGTM