search

diogot / danger-xcode_summary

A Danger plugin that shows all build errors, warnings and unit tests results generated from xcodebuild.
MIT License
137 stars 41 forks source link

Provide `sort_warnings_by` attribute to sort warnings #81

Closed InderKumarRathore closed 7 months ago

InderKumarRathore commented 11 months ago

Problem

In our code base we keep on deprecating the APIs and because of that the warning result is huge. And with GitHub's max issue comment size we can't see all the warnings and it's hard to find non deprecated warnings in the code with that huge list of warnings. Thus we miss important warning because of deprecated ones.

Solution

Provide a sort_warnings_by block that sorts the warnings, and with the help of this we can keep important warnings on top and less important warnings at the bottom

InderKumarRathore commented 8 months ago

@diogot did you get chance to review it.

diogot commented 7 months ago

Hi @InderKumarRathore, can you rebase and update? I'll merge it once the tests pass.