search

diogotr7 / OpenRGB.NET

C# client for the OpenRGB SDK
MIT License
40 stars 16 forks source link

Add support for listing and loading profiles #10

Closed sparten11740 closed 3 years ago

sparten11740 commented 3 years ago

Hey there,

as mentioned in this issue, the SDK now supports profile management. This pull request adds support for listing all available profiles on the server and load a profile by its name. I don't have much of a use case for saving profiles via the SDK myself, so I left that part out.

Hope this works for you.

wojciech-Kokot commented 3 years ago

is it possible make nudget or new version of dll I'm using powershell to manage devices I do not have visual studio to compile it.

diogotr7 commented 3 years ago

I looked into this and found something i think is a bug. Blocked by https://gitlab.com/CalcProgrammer1/OpenRGB/-/merge_requests/353

sparten11740 commented 3 years ago

I noticed that as well when I used your helper method and the 'p' was cutoff from the profile extension. Definitely makes sense to fix that upstream.

Edit: The upstream fix is merged, I added another commit that uses your helper method to unmarshal the profile names.

diogotr7 commented 3 years ago

Awesome, that's exactly what the helper method is for.

Thanks for contributing, i'll add the other profile related commands myself.