search

diogotr7 / OpenRGB.NET

C# client for the OpenRGB SDK
MIT License
40 stars 16 forks source link

Add EnumerateControllerData method. #8

Closed Desz01ate closed 3 years ago

Desz01ate commented 3 years ago

I have some use case that I want to filter out just some of the device type, instead of get all the controller device EnumerateControllerData is more compact than the GetAllControllerData in many way.

diogotr7 commented 3 years ago

Hello, thanks for cvontributing.

I would prefer a method that just returns an IEnumerable<Device> which you could use Where() on after. Would that be good enough for your use case?

Desz01ate commented 3 years ago

After taking a second look at GetAllControllerData signature I agree with you, I will submit only non-predicate version of EnumerateControllerData.

diogotr7 commented 3 years ago

It was easier to add it on my own than fixing the conflict. Thanks for contributing!