dionegoh / pe

0 stars 0 forks source link

able to add 2 students with the same name and same matriculation number #2

Open dionegoh opened 2 years ago

dionegoh commented 2 years ago

image.png

I am able to add 2 students with the same name and same matriculation number, even though UG states that matriculation number should be unique. In nus, matriculation numbers are not case-sensitive. Hence, i feel that a check to ensure that 2 matriculation numbers are the same should not be case-sensitive.

nus-pe-bot commented 2 years ago

Team's Response

Duplicate of #2838

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicate student IDs allowed with different capitalizations.

image.png

From the UG, it seems like duplicate student IDs should not be allowed in TAGA.

In this case, if the user were to make a change in the capitalization in the student ID, I should still expect to see an error message thrown. However, the system seems to allow for changes in capitalization in the student ID.

Commands used:

  1. add i/a9999999Z n/sally m/CS2103T p/98765432 t/sally e/e0123456@u.nus.edu
  2. add i/A9999999Z n/sally m/CS2103T p/98765432 t/sally e/e0123456@u.nus.edu

image.png

Not sure if this behaviour was intended as it is not specified in the UG, but it may be better to make the student ID case-insensitive or specify that it is case-sensitive in the UG.


[original: nus-cs2103-AY2122S2/pe-interim#2888] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We agree that this bug could cause a slight inconvenience for the user.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]