dionys / mojox-transaction-websocket76

MojoX::Transaction::WebSocket76 — container for WebSocket transactions as described in hixie-76 draft
Other
0 stars 1 forks source link

Fix for Mojolicious 6.40 and above #12

Open paultcochrane opened 8 years ago

paultcochrane commented 8 years ago

Update the module to use the new location for the constants previously imported from Mojo::Transation::WebSocket. Their new location is now Mojo::WebSocket. This PR makes the tests pass for Mojolicious versions 6.40 and above (and hence addresses issue #3), however breaks the code for Mojolicious versions below 6.40... Do you also wish to support the older versions in any future release of MojoX::Transaction::WebSocket76?

It turns out that the build_frame method has also been moved from Mojo::Transation::WebSocket into Mojo::WebSocket and it has consequently been deprecated. How exactly this issue is to be solved is not clear, however it is good to at least be aware that the method may one day be removed.

KES777 commented 8 years ago

+1 it is works. Thank you