Closed vuille5 closed 4 months ago
@vuille5 You need to format the code by doing the following
] add JuliaFormatter
in your own environment (not Dionysos env), then using JuliaFormatter
and finally format(".")
This will uniformize the code you wrote with the writing guidelines precised in ./.JuliaFormatter.toml
Merging #324 (722553e) into master (c9f65b3) will not change coverage. The diff coverage is
n/a
.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@ Coverage Diff @@
## master #324 +/- ##
=======================================
Coverage 82.29% 82.29%
=======================================
Files 57 57
Lines 4270 4270
=======================================
Hits 3514 3514
Misses 756 756
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Also @vuille5, you need your tests to be executed, so you have to add it in the ./test/runtests.jl
If you want to first test locally if it works, go to the Dionysos environnement by typing ] activate .
, then you should see (Dionysos)
in the package manager, then type
] test
This will execute ./test/runtests.jl
in the right environmenent. If it fails on the computer it will fail in the Github Actions.
New tests for bissection and newton method in a new folder optim inside the folder tests/utils.