search

dionysos-dev / Dionysos.jl

MIT License
40 stars 16 forks source link

Clarify difference between mappings #326

Open adrienbanse opened 7 months ago

adrienbanse commented 7 months ago

Clarify difference between mappings in src/mapping and xpos2int etc. in symbolic models (@egidioln could you help us with that? Is it really necessary that mapping is a distinct folder in the codebase?)

egidioln commented 7 months ago

Hey, sorry, I didn't se the tag...

As I said here, https://github.com/dionysos-dev/Dionysos.jl/issues/204#issuecomment-1546135227, Mapping would be a general (abstract) type that many others could inherit from (such as one implementing xpos2int)... But, again, I have no strong feeling that this is the best option so feel free to remove it if it doesn't make sense