search

dionyziz / Automata

An editor for deterministic finite automata
http://automata.discrete.gr
51 stars 12 forks source link

Fixed issue #9 #47

Closed DmitryMyadzelets closed 9 years ago

DmitryMyadzelets commented 9 years ago

The Runner (runner.js) has been slightly refactored and simlified s.t. it is more determenistic now. Also the existing method editor.gotoStep( steps ) has been changed to get the actual number of steps (i.e. a length of the substring) the automaton executed.

Acceptance is verified for the entire string only, not substrings (not sure it should be so).

When user provides a string which contains symbols not from the alphabet, a correspondent message appears (it was silent).

A string provided by the user is kept between rans now (it was reset to the default string before).

vasspilka commented 9 years ago

How can I reproduce the bug?

vasspilka commented 9 years ago

Everything seems to be working. Styling as expected. On line 71 there is a single line if, I don't see any problem with that though.

vasspilka commented 9 years ago

Reproduced the bug, it is fixed with this PR

dionyziz commented 9 years ago

This looks good, but please use feature branches in your fork next time so that you can work on different features in parallel. It helps instead of working on your master branch.

dionyziz commented 9 years ago

This looks good, PTAL at the comments and I'll merge you.

DmitryMyadzelets commented 9 years ago

After renaming the Runner's methods I have had to change all the names in correspondent files.