dionyziz / Automata

An editor for deterministic finite automata
http://automata.discrete.gr
51 stars 12 forks source link

Saved automata not loading #54

Closed gregth closed 8 years ago

gregth commented 8 years ago

Trying to load saved automata (using share links) is working inproperly. Specifically, sometimes it takes too much time to load the saved NFA and sometimes it doesn't even load it at all.

Example link of saved NFA: http://automata.discrete.gr/##v70

vasspilka commented 8 years ago

Try removing the extra # the the link is sometimes parsed wrong and adds an extra # where there should be none.

http://automata.discrete.gr/#v70

Cheers

gregth commented 8 years ago

The generated links contain a double #. Removing the extra # doesn't seem to be the solution to the problem. Actually it would seem a good idea the generated links not to contain a double #, but still I think it has nothing to do with the initial problem.

On Mon, Apr 18, 2016, 5:58 PM Vasilis Spilka notifications@github.com wrote:

Try removing the extra #

http://automata.discrete.gr/#v70

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/dionyziz/Automata/issues/54#issuecomment-211416344

vasspilka commented 8 years ago

A PR will be much appreciated :)

Here is what needs to be changed https://github.com/dionyziz/Automata/blob/master/site/js/ui.js#L43

vasspilka commented 8 years ago

My guess would be that if the link contains ONLY a # instead of #v it will add that extra #, also if anything else for that matter for example #123bebebe :D

So the automaton is not loading when the "url" is wrong like the one you initially shared. The reason it is slow is that it has to render the automaton locally through javascript, so if the automaton is complex it will take some time, a solution would be a loading animation, this way the the behavior is what would be expected.

vasspilka commented 8 years ago

Closing in favor of #55 and #56