userhelper::createNewUser method is fubar and needs to be rewritten pronto

dioscouri / library

5 stars 3 forks source link

userhelper::createNewUser method is fubar and needs to be rewritten pronto #20

Open rdiaztushman opened 11 years ago

rdiaztushman commented 11 years ago

This function is FUBAR. It is marked as static, but often uses $this-> At one point, it sets a property for an object ($msg) that doesn't exist. It needs to NOT be a static function so that it can send back an error message to the calling function.

ChrisFrench commented 11 years ago

I think atleast 3 of our components use this, Ambra, Tienda and Billets. So I will look into getting to this.