search

dioscouri / library

5 stars 3 forks source link

DSCGrid:sort optional task parameter not implemented #25

Open efillman opened 11 years ago

efillman commented 11 years ago

I've been trying to trace this function however it seems the parameter for an optional task is not implemented properly.

https://github.com/dioscouri/library/blob/master/lib_dioscouri/library/grid16.php#L115

ChrisFrench commented 11 years ago

Yea that could probably be cleaned up.

it looks like ours has the joomla 1.5 variable $form, instead of $task. and $task isn't used at all.

You can patch by changing renaming form to task, and the var inside and removing that extra far. I tried it and works fine, and we don't have the extra var

it like this

public static function sort( $title, $order, $direction = 'asc', $selected = 0, $task='document.adminForm', $new_direction = 'asc')

$html = '';