search

dioscouri / library

5 stars 3 forks source link

bootstrap breaks modal links #4

Closed ChrisFrench closed 11 years ago

ChrisFrench commented 12 years ago

I tried removing the bootstrap modal plugins but that still doesn't fix it.

rdiaztushman commented 12 years ago

After I removed the modal CSS classes, it worked for me on the featured-items component. Are you still having troubles after commit 3d0d4ee?

ChrisFrench commented 12 years ago

Last night on tienda the links didn't work like on products page On Jul 18, 2012 7:15 AM, "Rafael Diaz-Tushman" < reply@reply.github.com> wrote:

After I removed the modal CSS classes, it worked for me on the featured-items component. Are you still having troubles after commit 3d0d4ee?

Reply to this email directly or view it on GitHub: https://github.com/dioscouri/library/issues/4#issuecomment-7070028

rdiaztushman commented 12 years ago

ah ok, gotcha.

R

Rafael Diaz-Tushman, President & CEO Dioscouri Design: Form and Function www.dioscouri.com www.twitter.com/dioscouri w. 917-830-7411

On Wed, Jul 18, 2012 at 11:05 AM, Chris French < reply@reply.github.com

wrote:

Last night on tienda the links didn't work like on products page On Jul 18, 2012 7:15 AM, "Rafael Diaz-Tushman" < reply@reply.github.com> wrote:

After I removed the modal CSS classes, it worked for me on the featured-items component. Are you still having troubles after commit 3d0d4ee?

Reply to this email directly or view it on GitHub: https://github.com/dioscouri/library/issues/4#issuecomment-7070028

Reply to this email directly or view it on GitHub: https://github.com/dioscouri/library/issues/4#issuecomment-7071476

ChrisFrench commented 12 years ago

After bootstrapping a few things, I think we just need to not use bootstraps modal at all, it doesn't work with remote content anyway so for things like Tienda it isn't useful at all.

ChrisFrench commented 12 years ago

actually, I just figured out what the problem was.

I was calling DSC::loadBootstrap(); in the base view, and than Tienda was calling Tienda::url() in the main view.

So we were loading mootools than loading jQuery than loading mootools-more.js so none of the joomla extra features would work mainly modal windows.

if you make sure to load

JHTML::_('behavior.modal');

before you load jquery that means bootstrap or highcharts than they both work happy ever after