dioscouri / omnipay-cybersource

11 stars 13 forks source link

TransactionRef mixed up with TransactionId #15

Open eileenmcnaughton opened 9 years ago

eileenmcnaughton commented 9 years ago

I've realised that on the CompleteAuthorizeResponse we are returning

the customer defined id as $this->getTransactionReference() and the cybersource defined id as $this->getMerchantTransactionReference()

Whereas looking at Authorize.net, paypal & eway it seems that we should be using

getTransactionReference - Cybersource getTransactionId - customer.

NB - I doubt too many other people are using this so we should fix it now