dioscouri / omnipay-cybersource

11 stars 13 forks source link

PSR 2 required to meet contributing guidelines #9

Closed eileenmcnaughton closed 9 years ago

eileenmcnaughton commented 10 years ago

https://github.com/omnipay/omnipay/blob/master/CONTRIBUTING.md

We need to meet psr2 to contribute back - in particular we need unix style line breaks not windows style ones - I can see windows style ones coming in - presumably from your editor since I have mine trained I think

2.2 Files

All PHP files MUST use the Unix LF (linefeed) line ending.

All PHP files MUST end with a single blank line.

The closing ?> tag MUST be omitted from files containing only PHP.

eileenmcnaughton commented 10 years ago

nb code coverage is currently 64% - the 100% he asks for seems pretty high

eileenmcnaughton commented 9 years ago

Yep - all done :-)