search

dioscouri / tienda

3 stars 11 forks source link

I think we need to remove size attributes from select listsif size value is 1 #3

Open ChrisFrench opened 12 years ago

ChrisFrench commented 12 years ago

if we have size="1", and we have the the CSS selectors from bootstrap like select[multiple], select[size]

ChrisFrench commented 11 years ago

Hey Evan,

if you can handle this one as well. I figured I would give you to the two easiest ones to get you started. This one is just for UI, but we need to remove the size attribute form the select boxes if they are a size of 1, this is so they will match the styling that the bootstrapped library provides.

efillman commented 11 years ago

I could only find one instance of this behaviour in the tienda code? https://github.com/dioscouri/tienda/blob/master/tienda/admin/views/elementimage/view.php

ChrisFrench commented 11 years ago

I already removed a good chunk of them, but what you need to look for also is JHTML lines that have the attribs variable passed, the size option would be in there.

On Mon, Oct 22, 2012 at 8:36 AM, Evan Fillman notifications@github.comwrote:

I could only find one instance of this behaviour in the tienda code? https://github.com/dioscouri/tienda/blob/master/tienda/admin/views/elementimage/view.php

— Reply to this email directly or view it on GitHubhttps://github.com/dioscouri/tienda/issues/3#issuecomment-9665975.

rdiaztushman commented 11 years ago

Hey guys, as this is a non-critical styling improvement, i'm going to move it to a later milestone so we can focus on bug fixing first.

R