Image Search

[dipankar14]

@nesquena @timothy1ee

Image Search Assignment in folder: https://github.com/dipTech/AndroidDev/blob/master/GridSearch

Readme: https://github.com/dipTech/AndroidDev/blob/master/GridSearch/DipImageSearch.md

[vibhorB]

Nice work Dipankar. A few notes after checking out the code:

• Properly reused the single base method in search activity to fetch results for both initial load and the pagination
• Properly used spinners (with populated values) to allow users to select filters
• Good work on storing filters in file
• I didn't get to see any error handling or zoom effect in the GIF or the code.
• Consider better organizing your source files

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

[dipankar14]

@nesquena @timothy1ee

Thanks for reviewing the code:

For the error handling

1. If user click the right icon a Toast is shown "Click the gear icon on the action bar for settings"
2. If the query fail the method onFailure is executed for client.get
3. I have to add another failure for network disconnect and add the entry in manifest file.
4. For the zoom - I did it by the following code, but I will find a better way
   public void onClick(View view) { ivImage.setScaleType(ScaleType.FIT_XY); }

I will try to submit another version by next week will the optional requirement.

[vibhorB]

Hi Dipankar

Sorry for not being clear -

1. For error handling, I meant a more subtle way of checking network availability. I knew you had onFailure implemented, but not the network check. As a good practice, network calls shouldn't even be tried if network is not available.
2. The code for zoom just scales the image one time, it is not the actual zoom feature. setScaleType just scales the bounds of image to bounds of the view.

It is great to know you will be working on optional also, that is the best way to learn more and more.

Thanks Vibhor