search

dipaco / balu-python

Python implementation of Balu Toolbox by Domingo Mery (http://dmery.ing.puc.cl/index.php/balu/)
Other
5 stars 2 forks source link

Is Bfx_basicint Available in balu-python? #12

Closed jmarrietar closed 7 years ago

jmarrietar commented 7 years ago

I dont find Bfx_basicint code in balu python.

Thanks.

dipaco commented 7 years ago

No, sorry, Bfx_basicint is not implemented yet. In this first iteration i only added enough libraries for balu-python to be functional. However, this is a valuable function and easy to implement (now that I checked in Matlab).

There is a file called "Implemented_balu_comands" on the main folder. There you can see what commands are included and what aren't.

I think I will add this command to the list of next command to implement. You are welcome to do your own implementation and ask for pull request, I would be happy to add your contribution to the project. Ask me if you need more help.

dipaco commented 7 years ago

I just crated the file "ongoing commands" to list those commands we should work for the next iteratio of the library.

Also check Bfx_basicgeo.py, there are nice examples on how to use bwperim in python. Bwperim is necesary for bfx_basicint

jmarrietar commented 7 years ago

Hi, In order to implement Bfx_basicint, Bim_d1 and Bim_d2 would need to be Implemented First. I will write python implementation for this functions and let you for pull requests.

Thanks.

dipaco commented 7 years ago

Yes, that I checked. you have to implement also Bim_d2. Use the existing commands for documentation. Implement all three commands and then make de pull request, that's my recommendation.

Thank you. ᐧ

On Fri, Jan 27, 2017 at 5:19 PM, jmarrietar notifications@github.com wrote:

Hi, In order to implement Bfx_basicint, Bim_d1 would need to be Implemented First. I will write python implement for this functions and let you for pull requests.

Thanks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dipaco/balu-python/issues/12#issuecomment-275790609, or mute the thread https://github.com/notifications/unsubscribe-auth/ABJHL94df2xjyfatG8yp83b09G8498-dks5rWm1mgaJpZM4LwJrw .

-- Diego Patiño

jmarrietar commented 7 years ago

Hello,

I just Created the pull Request. Please review.

Thanks.

jmarrietar commented 7 years ago

Merged