search

dipc-cc / hubbard

Python tools for mean-field Hubbard models
https://dipc-cc.github.io/hubbard/
GNU Lesser General Public License v3.0
21 stars 8 forks source link

update for sisl change sc-to-lattice #136

Open tfrederiksen opened 1 year ago

tfrederiksen commented 1 year ago

This PR makes change to conform with the sc-to-lattice change now in sisl https://github.com/zerothi/sisl/pull/550.

zerothi commented 1 year ago

This might have the problem that you'll need to bump the sisl version, if that is what you want that is fine, but users who are installing sisl (via pip), and then using hubbard will have problems since it is not released yet.

tfrederiksen commented 1 year ago

This might have the problem that you'll need to bump the sisl version, if that is what you want that is fine, but users who are installing sisl (via pip), and then using hubbard will have problems since it is not released yet.

Good point. Maybe we should simply wait a while before merging this, say until a future sisl release.

zerothi commented 1 year ago

I am making a commit now that should re-enable the Geometry.sc handling, it would be nice if you could check that hubbard works, even with the lattice change.

zerothi commented 1 year ago

I have tried some of the examples, and they seem to work just fine! :) Great!

They raise a warning which they should! :)

zerothi commented 10 months ago

There are still many references to SuperCell...

tfrederiksen commented 10 months ago

There are still many references to SuperCell...

OK, let's wait with this PR to after the workshop.