search

dipc-cc / hubbard

Python tools for mean-field Hubbard models
https://dipc-cc.github.io/hubbard/
GNU Lesser General Public License v3.0
21 stars 8 forks source link

fixed missing EQCONTOUR and links to sisl-tutorials #146

Closed zerothi closed 10 months ago

zerothi commented 10 months ago

@sofiasanz this should fix #145 and also add the missing EQCONTOUR when doing installation.

Once merged, could you make a new release 0.4.1? Thanks!

tfrederiksen commented 10 months ago

Maybe #136 can also go in now?

zerothi commented 10 months ago

I mind a little ;) I want things done today, and things thoroughly tested, I need to ship out the installation script ASAP, so introducing something that may be a breaking change can be problematic.
If you do this, please run through all tutorials ASAP and let me know!

zerothi commented 10 months ago

136 will be post-poned to after the workshop.

@sofiasanz could you make a new release? Or are you testing things?

sofiasanz commented 10 months ago

136 will be post-poned to after the workshop.

@sofiasanz could you make a new release? Or are you testing things?

I am getting a wrong version when I install hubbard (see #147).

Do you know how to fix it?

zerothi commented 10 months ago

136 will be post-poned to after the workshop.

@sofiasanz could you make a new release? Or are you testing things?

I am getting a wrong version when I install hubbard (see #147).

Do you know how to fix it?

The problem is that your tags are not annotated! :)

When creating a tag, it is important to make it annotated, yes, this is annoying to remember:

git tag -a -m "message" v0.4.1

then it will work fine :)

sofiasanz commented 10 months ago

136 will be post-poned to after the workshop.

@sofiasanz could you make a new release? Or are you testing things?

I am getting a wrong version when I install hubbard (see #147). Do you know how to fix it?

The problem is that your tags are not annotated! :)

When creating a tag, it is important to make it annotated, yes, this is annoying to remember:

git tag -a -m "message" v0.4.1

then it will work fine :)

Oooh I see, thanks! I'll release the new tag, hopefully correctly this time :)

zerothi commented 10 months ago

Note I just did a PR and merged it, it should also make it stable against setuptools_scm... The version_file is perhaps a bit new, but the other one is deprecated according to their docs...

sofiasanz commented 10 months ago

Note I just did a PR and merged it, it should also make it stable against setuptools_scm... The version_file is perhaps a bit new, but the other one is deprecated according to their docs...

Yes, I included it in the last release :) thanks!