Closed RChutchev closed 4 months ago
@dipeshsukhia please participate
review changes for version 3.3.4 It looks good and the issue does not occur for any artisan command.
@dipeshsukhia, I'm sorry, but it looks like you missed something, I appreciate your work, but I'm getting this error for both (test and prod) environments. When I rollbacked the package to the previous version everything worked fine, but after upgrading to the new version I'm getting this error.
Here are no errors in ver. 3.3.3, but in 3.3.4 I'm getting this error, I'm not sure that this problem is Laravel-related b/c only your plugin upgrade caused this error, that's a real problem for us b/c we're using caching for website performance, you know and minification is required for the same reason, and I can't understand what is cause this error. How is 'dynamic-component' connected with your modification plugin, I'll check out, how to bypass this problem later, but maybe you can help me understand which modification in the new version of your package can cause this issue without code research/investigation from my side with your plugin code?
Hello, there is a problem with the new v3.3.4.
I'm getting an error with
php8.2 artisan view:cache
command.After the package is upgraded to the new version (Upgrading dipeshsukhia/laravel-html-minify (v3.3.3 => v3.3.4)), I get an error with the dynamic component, after downgrading back to v.3.3.3, the error is gone. I mean with the previous version, the command was executed successfully
INFO Blade templates cached successfully.
. I checked twice.I'm not sure what exactly goes on here, and why after your package upgraded Filament's related component 'dynamic-component' is unavailable, anyway can you help me with that, please?
PHP 8.2.0 Laravel 10.48.13 Filament 2.17.56
The file contains this code