search

dipien / bye-bye-jetifier

Gradle Plugin to verify if you can keep Android Jetifier disabled
http://byebyejetifier.dipien.com
Apache License 2.0
202 stars 5 forks source link

Indicate the dependencies graph of each scanned library with issues #21 #24

Closed giacomuzzi closed 3 years ago

giacomuzzi commented 3 years ago

Report example:

Scanning com.github.bumptech.glide:glide:3.8.0
 Graphs to this dependency:
 +---com.github.bumptech.glide:glide:3.8.0
 +---com.github.bumptech.glide:okhttp-integration:1.5.0
     +---com.github.bumptech.glide:glide:3.8.0
 +---com.gengqiquan:photoalbum:1.0.0
     +---com.github.bumptech.glide:glide:3.8.0
 Issues found:
 * com/bumptech/glide/Glide.class -> android/support/v4/app/FragmentActivity
 * com/bumptech/glide/Glide.class -> android/support/v4/app/Fragment
 * com/bumptech/glide/manager/RequestManagerRetriever.class -> android/support/v4/app/FragmentManager
 * com/bumptech/glide/manager/RequestManagerRetriever.class -> android/support/v4/app/FragmentActivity
 * com/bumptech/glide/manager/RequestManagerRetriever.class -> android/support/v4/app/Fragment
 * com/bumptech/glide/manager/RequestManagerRetriever.class -> android/support/v4/app/FragmentTransaction
 * com/bumptech/glide/manager/SupportRequestManagerFragment.class -> android/support/v4/app/Fragment
 * com/bumptech/glide/manager/SupportRequestManagerFragment.class -> android/support/v4/app/FragmentActivity
 * com/bumptech/glide/manager/SupportRequestManagerFragment.class -> android/support/v4/app/FragmentManager
maxirosson commented 3 years ago

There are conflicts to resolve before reviewing this PR.

giacomuzzi commented 3 years ago

I have just resolved all the conflicts

maxirosson commented 3 years ago

Is the first line after Graphs to this dependency: repeated? +---com.github.bumptech.glide:glide:3.8.0

giacomuzzi commented 3 years ago

That line is related to the first dependency declaration: 

    implementation("com.github.bumptech.glide:glide:3.8.0")
    implementation("com.github.bumptech.glide:okhttp-integration:1.5.0")
    implementation("com.gengqiquan:photoalbum:1.0.0")
maxirosson commented 3 years ago

ok. Makes sense