search

dipien / bye-bye-jetifier

Gradle Plugin to verify if you can keep Android Jetifier disabled
http://byebyejetifier.dipien.com
Apache License 2.0
202 stars 5 forks source link

It doesn't check all the aars in the libs folder #69

Open htafoyag opened 2 years ago

htafoyag commented 2 years ago

Describe the bug I have some aars with support dependencies that byebyejetifier is not identifying.

To Reproduce Steps to reproduce the behavior:

For example download swipe-reveal.layout.1.4.1.aar which throws errors if jetifier is not enabled,

If you apply the conversion with jetifier-standalone, then error goes away when running the app.

  1. Use default swipe-reveal.layout lib withoutjetifier-standalone, in a project with jetifierEnabled = false
  2. Run ./gradlew canISayByeByeJetifier -Pandroid.enableJetifier=false
  3. Build will be successful
  4. Run the app where the swipereveallayout is used, it will throw error regarding support libraries.

Expected behavior ByebyeJetifier should detect the classes where support libs are used.

Additional context I have over 20 aar libs in my project, knowing that byebyejetifier is not correctly checking all of them requires me to apply jetifier-standalone to everyone of them to assure no problem will happen.

The following aar also presents problems, probably it is not being detected from the way it is implemented as a module:

image