search

diprajpatra / selenium-stealth

Trying to make python selenium more stealthy.
MIT License
607 stars 88 forks source link

Error in user_agent_override.py #7

Open dornech opened 3 years ago

dornech commented 3 years ago

I think these lines in user_agent_override.py are not correct wrong.

if language and platform:
    override = {"userAgent": ua, "acceptLanguage": language, "platform": platform}
elif not language and platform:
    override = {"userAgent": ua, "acceptLanguage": language, "platform": platform}
elif language and not platform:
    override = {"userAgent": ua, "acceptLanguage": language, "platform": platform}
else:
    override = {"userAgent": ua}

I think they should read

if language and platform:
    override = {"userAgent": ua, "acceptLanguage": language, "platform": platform}
elif not language and platform:
    override = {"userAgent": ua, "platform": platform}
elif language and not platform:
    override = {"userAgent": ua, "acceptLanguage": language}
else:
    override = {"userAgent": ua}