CFG example: using bigrams instead of binarization

diprism / fggs

Factor Graph Grammars in Python

MIT License

13 stars 3 forks source link

CFG example: using bigrams instead of binarization #124

Closed davidweichiang closed 2 years ago

davidweichiang commented 2 years ago

The "pattern" mode was using too much memory for GPU, and I also didn't like the fact that we had to do binarization, so this instead creates a factor for each bigram instead of a factor for the whole rule.

[x] Haven't tested yet whether it fits into GPU memory

davidweichiang commented 2 years ago

Can we merge this? It's a relatively small change.

davidweichiang commented 2 years ago

OK, I added a bunch more comments!

darcey commented 2 years ago

Thank you so much!! The comments are extremely appreciated.