search

diprism / fggs

Factor Graph Grammars in Python
MIT License
13 stars 3 forks source link

Barebones packaging #134

Closed davidweichiang closed 2 years ago

davidweichiang commented 2 years ago

Uses setup.cfg only, not setup.py, since the latter seems to be deprecated.

Unfortunately, requirements.txt currently points to a git repository and this seems to be not allowed in setup.cfg or setup.py, so we can't delete requirements.txt yet.

Closes #133

kennethsible commented 2 years ago

@davidweichiang In requirements.txt, we have

#torch-semiring-einsum
-e git+https://github.com/diprism/semiring-einsum@fgg#egg=torch-semiring-einsum

but in setup.cfg, you use torch-semiring-einsum. I thought the package install wasn't the right version?

kennethsible commented 2 years ago

Ah, I see you addressed that in your description.