Fix various bugs revealed by enabling more tests.

diprism / fggs

Factor Graph Grammars in Python

MIT License

13 stars 3 forks source link

Closed davidweichiang closed 2 years ago

davidweichiang commented 2 years ago

Changed the stopping criterion for Newton's method; the old stopping criterion was ont working well when the Jacobian is zero at the solution.
Newton's method seems to work on the unclean examples; is cleaning not actually necessary?

davidweichiang commented 2 years ago

Possibly closes #52

davidweichiang commented 2 years ago

@kennethsible Can you take a quick look? I think this should be an easy check.