search

diprism / fggs

Factor Graph Grammars in Python
MIT License
13 stars 3 forks source link

Reorganize into a package #43

Closed davidweichiang closed 3 years ago

davidweichiang commented 3 years ago

I did the simplest thing which was to put all the symbols exported by all the modules into the top-level package. If desired, we can keep some symbols in submodules.

davidweichiang commented 3 years ago

Closes #41.

davidweichiang commented 3 years ago

Hm, the tests work for me locally (python -m unittest from the root directory) but something is wrong here.

davidweichiang commented 3 years ago

OK, I think this is ready now.

davidweichiang commented 3 years ago

It doesn't matter to me who reviews this; I requested @kennethsible because @darcey is theoretically on vacation :)

darcey commented 3 years ago

I am on vacation! :) But I wanted to be available to review code as needed. (However, I'm not sure I'm qualified to review this PR -- I've never made a Python package before. If @kennethsible has more experience with this, I would defer to him.)

kennethsible commented 3 years ago

I am also on vacation; Iceland from July 13 to July 18. However, I can review the pull request tonight since I brought a laptop. I created a Python package before, so I am acquainted with the structure.

kennethsible commented 3 years ago

@davidweichiang I would suggest (as a rule-of-thumb) using absolute imports in a package instead of relative imports since the directory structure could change in the future