search

diprism / fggs

Factor Graph Grammars in Python
MIT License
13 stars 3 forks source link

Fix diff_index and tau_R Bug in Sum-Product #80

Closed kennethsible closed 2 years ago

kennethsible commented 2 years ago

Closes #78

davidweichiang commented 2 years ago

@kennethsible do you want to just push what you've got to a branch and maybe I can help to move it along?

davidweichiang commented 2 years ago

@kennethsible There is a lot to do that is being held up by this. Can you push pieces of what you've got, instead of waiting to push one big thing, so that other pieces can move forward?

kennethsible commented 2 years ago

I'll push tonight tomorrow morning (all unit tests are passing)

kennethsible commented 2 years ago

@davidweichiang I pushed my current work to #84. If you merge #84, I believe that we can now merge #80. You mentioned that you implemented half of the fix (for F not J) in #82 and that we should just merge #84, continuing the fix in #82.

davidweichiang commented 2 years ago

Obviated by #84 .