Straighten out types in FGG/RuleM/Compile - Githubissues

diprism / perpl

The PERPL Compiler

MIT License

10 stars 5 forks source link

Straighten out types in FGG/RuleM/Compile #105

Closed davidweichiang closed 1 year ago

davidweichiang commented 1 year ago

This is a big set of changes, but the summary is:

Instead of using Strings everywhere, define new types for Value, NodeName, NodeLabel, and EdgeLabel. These are no longer Strings, but structured objects.
Remove the type parameter d from FGG, HGF, etc. NodeLabel (which is a synonym for Type) takes its place.
A special case for creating a start rule was removed; I don't think it was necessary.
The dangling edges created by discardEdges' were removed; I don't think they were necessary.

Hopefully it should be clearer now where Vars used (for #107).

ccshan commented 1 year ago

I never really understood the FGG type so I expect to review whether I can understand this FGG type rather than the changes~