search

dipterix / threeBrain

3D Visualization of Brain MRI
https://dipterix.org/threeBrain/
42 stars 10 forks source link

Not rendered correctly on some Windows - shader errors #21

Closed dipterix closed 2 years ago

dipterix commented 2 years ago

Some RAVE customized shaders use medium precision to improve performance. However, three.js might add some definitions before the shader, causing switching precision when WebGL tries to compile the shaders.

The cause of this issue has not been fully investigated, and I only see it on UTM virtualized windows 11 (firefox) (host machine is OSX, intel-based)

This could be the cause of shader errors we see on some intel-based OSX

dipterix commented 2 years ago

The bug (not a bug actually) is not caused by using mediump. Instead, the issue was caused by browser not supporting WebGL2 + glsl3. The UTM virtual machine has low configurations and Firefox about:support page suggests.

WebGL 2 Driver Renderer WebGL creation failed: 
* AllowWebgl2:false restricts context creation on this system. ()

Since WebGL2 is not well supported, I wouldn't expect threeBrain to work on such platforms as WebGL2 is a must.

In modern computers + browsers, WebGL2 with GLSL3 support is expected. Closing this edge case