search

dirac-institute / kbmod

KBMOD (Kernel-Based Moving Object Detection)
BSD 2-Clause "Simplified" License
46 stars 14 forks source link

add tqdm disabling option #689

Closed maxwest-uw closed 2 months ago

maxwest-uw commented 3 months ago

resolves #688

also adds the progress bar to the lazy work unit reprojection changes (which weren't merged at the time of the original pr 😅 )

maxwest-uw commented 3 months ago

part one of your request (being able to set PROGRESS_BAR at runtime) doesn't seem to work, as the downstream import in WorkUnit only ever seems to load what it was initially

DinoBektesevic commented 3 months ago

Importing it will make a copy of the variable and then keep it in the module's global namespace. You have to get your values from where they're defined. I rejiggered the global variable access and removed some unused imports. This seems to work fine for me now, perhaps double check.

maxwest-uw commented 2 months ago

looks good to me (can I say that on my on pr? 😭 )

DinoBektesevic commented 2 months ago

Merge it then :D