search

dirac-institute / kbmod

KBMOD (Kernel-Based Moving Object Detection)
BSD 2-Clause "Simplified" License
46 stars 14 forks source link

Pass the location information to the WorkUnit #738

Closed jeremykubica closed 2 weeks ago

jeremykubica commented 2 weeks ago

This is a step in better propagation of provenance information. Pass information from the standardizer's location field to the WorkUnit. This might not provide perfect information about the data source. For example in memory fits files will just produce ":memory:".

DinoBektesevic commented 2 weeks ago

This is probably not the right way to do it. I would use toBinTableHDU and append it to the HDUList of a WorkUnit. If you want to add an imagecollection property to the WorkUnit there's a fromBinTableHDU on an imagecollection. As you note location is not a unique init key required by Standardizers.

This was blocked for a bit by messy metadata tracking within WorkUnit. Some of this was cleaned up so I guess we can do it. It can't hurt to add it, but I've seen WU with 700+ HDUs. It's probs more worth to clean that up in comparison, mostly because we don't keep WUs around during/after processing due to their size.

jeremykubica commented 2 weeks ago

Closing since Dino indicates there is a better way to do this.