dirac-institute / sorcha

An open-source community LSST Solar System Simulator
Other
18 stars 18 forks source link

miniDifi: bugfix for discovery options past discovery window #1002

Closed mjuric closed 3 months ago

mjuric commented 3 months ago

Say our discovery window is 10, and the object has tracklets at nights:

2 4 6 8

This should generate the following discovery opportunities:

2 4 6
2 4 6 8
  4 6 8

The code before this bugfix would stop looking for discovery opportunities after the final night was reached, so it didn't "see" the last one combination.

Fixes # .

Describe your changes.

Review Checklist for Source Code Changes

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.78%. Comparing base (a1548a3) to head (c661f54). Report is 70 commits behind head on main.

Files with missing lines Patch % Lines
src/sorcha/modules/PPMiniDifi.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1002 +/- ## ========================================== - Coverage 80.89% 80.78% -0.12% ========================================== Files 69 69 Lines 3094 3107 +13 ========================================== + Hits 2503 2510 +7 - Misses 591 597 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

mjuric commented 3 months ago

This codecov fail is bogus. You can verify by dropping the + window on that line, and seeing the unit tests fail. Blah.

image