codecov[bot]
commented
2 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 80.90%. Comparing base (
8ca77c6) to head (c2b800c). Report is 21 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1016 +/- ## ========================================== + Coverage 80.78% 80.90% +0.12% ========================================== Files 69 70 +1 Lines 3107 3148 +41 ========================================== + Hits 2510 2547 +37 - Misses 597 601 +4 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes #1008.
_remove_files()wasn't being imported, fixed that.From the error trace for the failed checks on #1014, it looks like the problem wasn't the SPICE kernels, which Meg had updated correctly: it was that numba now requires scipy as a dependency, which wasn't in the pyproject.toml file.
This is because sbpy 0.4.0 required synphot which required scipy, so when the checks pip-installed sbpy, they were installing scipy as well even though we didn't explicitly list it as a requirement. However, sbpy released 0.5.0 on August 28th, and this version no longer requires synphot or scipy, so scipy was not being installed as a requirement and numba failed. Numba has scipy as an optional requirement, so it isn't installed by default with numba.
Review Checklist for Source Code Changes