dirac-institute / sorcha

An open-source community LSST Solar System Simulator
Other
16 stars 17 forks source link

Fixing config parser for bright limit #1024

Closed astronomerritt closed 3 days ago

astronomerritt commented 4 days ago

Fixes #1022.

Desired behaviour:

Actual behaviour:

Fix:

Review Checklist for Source Code Changes

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (c2b800c) to head (8ab8dbf). Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/sorcha/modules/PPConfigParser.py 41.66% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1024 +/- ## ========================================== + Coverage 80.90% 81.04% +0.13% ========================================== Files 70 70 Lines 3148 3149 +1 ========================================== + Hits 2547 2552 +5 + Misses 601 597 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

astronomerritt commented 4 days ago

Please ignore CodeCov, PPConfigParser is impossible to unit test properly in its current form. (One day I'll fix it. ONE DAY.)