dirac-institute / sorcha

An open-source community LSST Solar System Simulator
Other
18 stars 18 forks source link

Adding method to check IDs #1025

Closed astronomerritt closed 1 month ago

astronomerritt commented 2 months ago

Fixes #1001.

Meg: this isn't the way we discussed implementing it. I think it's better. Feel free to disagree :)

Dataframes aren't merged until chunking has begun. If we check dataframe size on merge, there's a possibility that the user could get to chunk 999 of 1000 and THEN have the code fail because the ObjIDs don't match. This would be very annoying.

This method checks once, using code Jeremy already wrote, and takes 1.4s on 10k-row input files. I think it's worth it.

Review Checklist for Source Code Changes

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.12%. Comparing base (c2b800c) to head (b70aa3e). Report is 16 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1025 +/- ## ========================================== + Coverage 80.90% 81.12% +0.21% ========================================== Files 70 70 Lines 3148 3163 +15 ========================================== + Hits 2547 2566 +19 + Misses 601 597 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.