Closed astronomerritt closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.12%. Comparing base (
c2b800c
) to head (b70aa3e
). Report is 16 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes #1001.
CombinedObjectReader.check_aux_object_ids()
, that uses existing code to check that the ObjIDs in the auxiliary input files are an exact match for each other.Meg: this isn't the way we discussed implementing it. I think it's better. Feel free to disagree :)
Dataframes aren't merged until chunking has begun. If we check dataframe size on merge, there's a possibility that the user could get to chunk 999 of 1000 and THEN have the code fail because the ObjIDs don't match. This would be very annoying.
This method checks once, using code Jeremy already wrote, and takes 1.4s on 10k-row input files. I think it's worth it.
Review Checklist for Source Code Changes