dirac-institute / sorcha

An open-source community LSST Solar System Simulator
Other
18 stars 17 forks source link

Simplifying detection efficiency validation notebook. #1035

Closed astronomerritt closed 1 month ago

astronomerritt commented 1 month ago

The notebook demonstrating the fading function/detection efficiency had a lot of extraneous code and while-loops instead of array operations, and was also missing an explanation of the fading function. I had to edit it anyway to make plots for the paper, so figured I may as well overhaul it while I was there.

Review Checklist for Source Code Changes

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.14%. Comparing base (c2b800c) to head (59c9f77). Report is 27 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1035 +/- ## ========================================== + Coverage 80.90% 81.14% +0.23% ========================================== Files 70 70 Lines 3148 3166 +18 ========================================== + Hits 2547 2569 +22 + Misses 601 597 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.