search

dirac-institute / sorcha

An open-source community LSST Solar System Simulator
Other
18 stars 17 forks source link

Some functions aren't used in the code #1051

Closed astronomerritt closed 2 weeks ago

astronomerritt commented 1 month ago

These functions:

https://github.com/dirac-institute/sorcha/blob/e385ee0a8ee504ca1585afa7369365f664bd5e38/src/sorcha/modules/PPJoinEphemeridesAndParameters.py#L1-L24

https://github.com/dirac-institute/sorcha/blob/e385ee0a8ee504ca1585afa7369365f664bd5e38/src/sorcha/modules/PPJoinEphemeridesAndOrbits.py#L5-L30

They're only used in one place: the unit test for PPMatchPointingToObservations().

They are one-line functions which perform simple Pandas joins. I propose we remove these files/functions and their unit tests, and replace them in test_PPMatchPointingToObservations() with the Pandas join.

astronomerritt commented 1 month ago

We're also not using PPCheckInputObjectIDs() anywhere at all.

https://github.com/dirac-institute/sorcha/blob/e385ee0a8ee504ca1585afa7369365f664bd5e38/src/sorcha/modules/PPCheckInputObjectIDs.py#L1-L47

mschwamb commented 1 month ago

nice catch