dirac-institute / sorcha

An open-source community LSST Solar System Simulator
Other
18 stars 17 forks source link

Remove extra cos(dec) to ra rate in magnitude uncertainty trailing loss calculation #881

Closed mschwamb closed 7 months ago

mschwamb commented 7 months ago

this line needs to be changed

https://github.com/dirac-institute/sorcha/blob/50985097f09c122b1696ce1307544ec766cf6ea8/src/sorcha/modules/PPAddUncertainties.py#L193-L195

as ephemeris generations calculates ra*cos(dec) rate by default

mschwamb commented 7 months ago

It would be good to double check that the demo notebook is doing the right comparisons