search

dirac-institute / sorcha

An open-source community LSST Solar System Simulator
Other
18 stars 17 forks source link

converting object id to string should have in read in function not in suverysimpp #94

Closed mschwamb closed 2 years ago

mschwamb commented 2 years ago 
 # comets may have dashes in their names that mix things up
        observations['ObjID'] = observations['ObjID'].astype(str)

Should be moved to the read in function for the observations file rather than in the main (surveysimpp) so it's clear this is associated with the readin and all functions downstream of readin are ensured to have the ObjID in the right format

fedorets commented 2 years ago

The line will be moved to all four read-in functions.

fedorets commented 2 years ago

Fixid in pulled request #98.