search

dirac-institute / sorcha

An open-source community LSST Solar System Simulator
Other
16 stars 17 forks source link

get answers to minidifi questions #942

Closed mschwamb closed 2 months ago

mschwamb commented 5 months ago

miniDifi Issues.pdf

mjuric commented 3 months ago

I think I have these sorted out on the minidifi-fixes branch, but I'd need someone to test it prior to merging.

There were three bugs, affecting two things -- a) two bugs around the calculation of the number of discovery opportunities (also affecting the calculation of whether the object has been discovered, but rarely in practice as Rubin linker has p=.95 and usually many discovery opportunities), and b) a bug where Sorcha could crash when computing the ID of the "asterisk-ed" observation (which was never triggered because of the other two bugs).

@astjoephysics , could you try running your notebook & see it they agree better now? If there are any differences, let's get together on Zoom & try to sort it out.